feat(helm): add custom labels to ServiceMonitor#384
Closed
nikatza wants to merge 1 commit into
Closed
Conversation
nikatza
force-pushed
the
expose-prometheus-metrics
branch
from
0d38685 to
c0b281b
Compare
Add prometheus.labels field in values.yaml to allow custom labels on the ServiceMonitor resource. This enables integration with monitoring systems that use labels for scrape discovery. The Makefile charts target preserves this change when kubebuilder regenerates templates. Adds omit filter to prevent users to overwrite managed labels. Signed-off-by: Pujol <enric.pujol@sap.com>
nikatza
force-pushed
the
expose-prometheus-metrics
branch
from
c0b281b to
c77bb56
Compare
Contributor
Author
|
@felix-kaestner closing this PR as per the suggestion to use kustomize in our own charts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add prometheus.labels field in values.yaml to allow custom labels on the ServiceMonitor resource. This enables integration with monitoring systems that use labels for scrape discovery.
The Makefile charts target preserves this change when kubebuilder regenerates templates.
Example: